Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] Add minor Korean translations to ability-trigger file (costar,trace) #3087

Closed
wants to merge 5 commits into from
Closed

[Localization] Add minor Korean translations to ability-trigger file (costar,trace) #3087

wants to merge 5 commits into from

Conversation

smee6
Copy link
Contributor

@smee6 smee6 commented Jul 21, 2024

What are the changes?

  1. Add Korean translation for costar ability trigger
  2. Add Korean translation for trace ability trigger
    refered from Pokémon Scarlet and Violet's official translation.

Why am I doing these changes?

Fix missing Korean translations for costar and trace abilities in ability-trigger file to enhance user immersion.

What did change?

Before the PR

The abilities costar and trace lacked Korean translations.
Korean-native players faced interruptions in immersion due to untranslated ability descriptions.


After the PR
Added Korean translations for the costar and trace abilities.
Korean-native players will now see consistent translations, improving their gaming experience and immersion.

How to test the changes?

  1. Installed the project locally using npm install.
  2. Played with Polygon and Flamigo to ensure costar and trace description is shown correctly.

Checklist

  • [v] There is no overlap with another PR?
  • [v] The PR is self-contained and cannot be split into smaller PRs?
  • [v] Have I provided a clear explanation of the changes?
  • [v] Have I tested the changes (manually)?
    • [v] Are all unit tests still passing? (npm run test)

flx-sta and others added 4 commits July 21, 2024 14:32
@flx-sta
[Feature] replace bug-report template with form (#2772)
6e07942 
* replace bug-report template with form

* update bug_report.yml

* add palceholders for data & session file
@smee6
Add minor Korean translations to ability-trigger file
33543f7 
Add minor Korean translations to ability-trigger file.

1. Add Korean translation for costar ability trigger
2. Add Korean translation for trace ability trigger
@smee6
Update ability-trigger.ts
4cd69dc
@smee6
Update ability-trigger.ts
70dcb21
@flx-sta flx-sta added the Localization Provides or updates translation efforts label Jul 21, 2024
@Tempo-anon Tempo-anon changed the base branch from main to beta July 21, 2024 18:28
@smee6
Copy link
Contributor Author

smee6 commented Jul 22, 2024

trace_ko_description

For "trace", Conflict should be resolved as current commit #3087. (ref. above image / official translation)
but for the "costar", "costar": "{{pokemonName}}[[는]] {{allyName}}의\n능력 변화를 복사했다!", would be okay.
cuz in the sentence with '\n' has more readability.

@Tempo-anon
Copy link
Collaborator

Can you fix the merge conflicts such as the things in .github/ISSUE_TEMPLATE? You should be starting your PRs from beta since that's where merges should go

@smee6 smee6 closed this Jul 22, 2024
@smee6 smee6 mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tempo-anon Tempo-anon Tempo-anon approved these changes

Assignees
No one assigned
Labels
Localization Provides or updates translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smee6 @Tempo-anon @flx-sta